Change ruleId if it exists #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezzago
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
============================================
- Coverage 25.04% 25.04% -0.01%
Complexity 943 943
============================================
Files 255 255
Lines 11123 11126 +3
Branches 1242 1243 +1
============================================
Hits 2786 2786
- Misses 8086 8089 +3
Partials 251 251
|
AWSHurneyt
previously approved these changes
Oct 3, 2023
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
force-pushed
the
handleduplicates
branch
from
abdb6a6 to
e4aeac9
Compare
Signed-off-by: Ashish Agrawal <[email protected]>
sbcd90
approved these changes
Oct 3, 2023
AWSHurneyt
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 03573e9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 03573e9)
lezzago
added a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 03573e9) Co-authored-by: Ashish Agrawal <[email protected]>
lezzago
added a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 03573e9) Co-authored-by: Ashish Agrawal <[email protected]>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…t#628) (opensearch-project#630) * refactored DeleteMonitor Action to be synchronious Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Petar Dzepina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there are duplicate rules, the rules would overwrite each other when they are in different categories. This modifies the document id for the rule, so they dont overwrite each other.
Issues Resolved
#610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.