Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10] Backport 2.x adds support for alerts and triggers on group by based sigma rules (#545) #560

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 24fe8d4 from #559

…igma rules (#545) (#559)

* adds support for alerts and triggers on group by based sigma rules  (#545)

* fix test

Signed-off-by: Surya Sashank Nistala <[email protected]>

* adds support for alerts and triggers on group by based rules

Signed-off-by: Surya Sashank Nistala <[email protected]>

* change setting workflow usage enabled to true by default

Signed-off-by: Surya Sashank Nistala <[email protected]>

* turn off workflow setting for test

Signed-off-by: Surya Sashank Nistala <[email protected]>

* revert new line

Signed-off-by: Surya Sashank Nistala <[email protected]>

* support feeding findings to chained finding monitors ONLY from rules mentioned in detector triggers

Signed-off-by: Surya Sashank Nistala <[email protected]>

* revert naming convention change for bucket level monitors

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix compile issue from main and 2.x dependency divergence

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 24fe8d4)
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #560 (1607397) into 2.10 (766033c) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               2.10     #560      +/-   ##
============================================
- Coverage     25.14%   25.02%   -0.13%     
- Complexity      940      941       +1     
============================================
  Files           255      255              
  Lines         11062    11123      +61     
  Branches       1231     1242      +11     
============================================
+ Hits           2782     2783       +1     
- Misses         8028     8089      +61     
+ Partials        252      251       -1     
Files Changed Coverage Δ
...earch/securityanalytics/model/DetectorTrigger.java 54.85% <0.00%> (-1.29%) ⬇️
...yanalytics/settings/SecurityAnalyticsSettings.java 96.00% <ø> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...ensearch/securityanalytics/util/DetectorUtils.java 0.00% <0.00%> (ø)
...search/securityanalytics/util/WorkflowService.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@sbcd90 sbcd90 merged commit a59bb63 into 2.10 Sep 9, 2023
@github-actions github-actions bot deleted the backport/backport-559-to-2.10 branch September 9, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants