Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment replication changes #529

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Sep 1, 2023

Description

[Describe what this change achieves]

Issues Resolved

#473

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <[email protected]>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #529 (344c18f) into main (4339b84) will decrease coverage by 0.07%.
The diff coverage is 6.97%.

@@             Coverage Diff              @@
##               main     #529      +/-   ##
============================================
- Coverage     25.83%   25.77%   -0.07%     
  Complexity      942      942              
============================================
  Files           252      252              
  Lines         10735    10768      +33     
  Branches       1197     1197              
============================================
+ Hits           2773     2775       +2     
- Misses         7715     7746      +31     
  Partials        247      247              
Files Changed Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 2.43% <0.00%> (-0.07%) ⬇️
...arch/securityanalytics/correlation/JoinEngine.java 0.00% <0.00%> (ø)
...yanalytics/correlation/VectorEmbeddingsEngine.java 0.00% <0.00%> (ø)
...s/resthandler/RestSearchCorrelationRuleAction.java 0.00% <0.00%> (ø)
...nalytics/resthandler/RestSearchDetectorAction.java 0.00% <0.00%> (ø)
...ityanalytics/resthandler/RestSearchRuleAction.java 0.00% <0.00%> (ø)
...ics/transport/TransportCorrelateFindingAction.java 0.00% <0.00%> (ø)
...analytics/transport/TransportDeleteRuleAction.java 0.00% <0.00%> (ø)
...yanalytics/transport/TransportGetAlertsAction.java 0.00% <0.00%> (ø)
...nalytics/transport/TransportGetFindingsAction.java 0.00% <0.00%> (ø)
... and 8 more

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbcd90 for this quick change.

Overall changes look good to me, please verify below before merge that for all requests where you added _primary_first preference:

  1. Your plugin needs strong reads.
  2. You are using IMMEDIATE, WAIT_UNTIL refresh policy for data ingestion. This is because, use of these refresh policies were giving strong reads guarantees before. So, if these are not used, it probably means you don't need strong reads for those search requests.

@sbcd90 sbcd90 merged commit af05189 into opensearch-project:main Sep 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit af05189)
sbcd90 pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants