-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
segment replication changes #529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni and
eirsep
as code owners
September 1, 2023 18:29
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
============================================
- Coverage 25.83% 25.77% -0.07%
Complexity 942 942
============================================
Files 252 252
Lines 10735 10768 +33
Branches 1197 1197
============================================
+ Hits 2773 2775 +2
- Misses 7715 7746 +31
Partials 247 247
|
dreamer-89
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbcd90 for this quick change.
Overall changes look good to me, please verify below before merge that for all requests where you added _primary_first
preference:
- Your plugin needs strong reads.
- You are using IMMEDIATE, WAIT_UNTIL refresh policy for data ingestion. This is because, use of these refresh policies were giving strong reads guarantees before. So, if these are not used, it probably means you don't need strong reads for those search requests.
getsaurabh02
approved these changes
Sep 1, 2023
eirsep
approved these changes
Sep 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit af05189)
sbcd90
pushed a commit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
#473
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.