Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logtypes pr v2 #482

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Logtypes pr v2 #482

merged 1 commit into from
Jul 11, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Jul 11, 2023

Description

Logtypes pr v2

Issues Resolved

solves part of #459

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <[email protected]>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #482 (09e0e1d) into 2.x (2e869e5) will decrease coverage by 0.03%.
The diff coverage is 25.34%.

@@             Coverage Diff              @@
##                2.x     #482      +/-   ##
============================================
- Coverage     28.24%   28.22%   -0.03%     
- Complexity      904      939      +35     
============================================
  Files           235      236       +1     
  Lines          9446     9864     +418     
  Branches       1081     1118      +37     
============================================
+ Hits           2668     2784     +116     
- Misses         6546     6839     +293     
- Partials        232      241       +9     
Impacted Files Coverage Δ
...rch/securityanalytics/action/GetAlertsRequest.java 0.00% <0.00%> (ø)
...h/securityanalytics/action/GetFindingsRequest.java 0.00% <0.00%> (ø)
...rch/securityanalytics/action/IndexRuleRequest.java 0.00% <ø> (ø)
...search/securityanalytics/alerts/AlertsService.java 21.90% <0.00%> (ø)
...rrelation/index/codec/CorrelationCodecService.java 0.00% <0.00%> (ø)
...ch/securityanalytics/findings/FindingsService.java 36.48% <0.00%> (ø)
...indexmanagment/DetectorIndexManagementService.java 0.00% <0.00%> (ø)
...ecurityanalytics/logtype/BuiltinLogTypeLoader.java 2.27% <0.00%> (+2.27%) ⬆️
...earch/securityanalytics/logtype/MappingSchema.java 0.00% <0.00%> (ø)
...search/securityanalytics/mapper/MapperService.java 0.00% <0.00%> (-4.29%) ⬇️
... and 17 more

... and 2 files with indirect coverage changes

@sbcd90 sbcd90 added the backport 2.9 backports to 2.9 label Jul 11, 2023
@sbcd90 sbcd90 merged commit 9788781 into opensearch-project:2.x Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>
(cherry picked from commit 9788781)
sbcd90 pushed a commit that referenced this pull request Jul 12, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing opensearch-project#487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.9 backports to 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants