correlation rule search, delete and edit api #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
============================================
- Coverage 28.23% 28.18% -0.05%
- Complexity 906 940 +34
============================================
Files 235 236 +1
Lines 9443 9863 +420
Branches 1081 1118 +37
============================================
+ Hits 2666 2780 +114
- Misses 6545 6841 +296
- Partials 232 242 +10
|
getsaurabh02
approved these changes
Jul 11, 2023
amsiglan
approved these changes
Jul 11, 2023
eirsep
approved these changes
Jul 11, 2023
| ); | ||
| } | ||
|
|
||
| @Override | ||
| protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient client) throws IOException { | ||
| log.debug(String.format(Locale.ROOT, "%s %s", request.method(), SecurityAnalyticsPlugin.CORRELATION_RULES_BASE_URI)); | ||
|
|
||
| String id = request.param("rule_id", CorrelationRule.NO_ID); | ||
| String id = request.param("correlation_rule_id", CorrelationRule.NO_ID); |
There was a problem hiding this comment.
is this a breaking change from previous version?
There was a problem hiding this comment.
this piece of code was not used in previous releases. today while writing integ tests i found this error. so changed this.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 61715cd)
sbcd90
added a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
correlation rule search, delete and edit api
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.