Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation Rules fixes #468

Closed
wants to merge 2 commits into from

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Jun 22, 2023

Description

  1. fixed bucket_path for count agg
  2. fixed importing prepackaged agg rules

Issues Resolved

#458

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Petar Dzepina <[email protected]>
@dnhodgson
Copy link

Any movement on getting this merged?

absvoid added a commit to absvoid/security-analytics that referenced this pull request Aug 18, 2023
@dnhodgson
Copy link

2.10 hopefully?

@sbcd90
Copy link
Collaborator

sbcd90 commented Sep 7, 2023

hi @dnhodgson , we're currently refactoring the sigma aggregation rules workflow. we'll look into this pr in 2.11.

@praveensameneni
Copy link
Member

Changes added into a new PR#640

@sbcd90
Copy link
Collaborator

sbcd90 commented Oct 5, 2023

closing this pr.

@sbcd90 sbcd90 closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants