New Log Type JSON format #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Dzepina <[email protected]>
petardz
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
============================================
+ Coverage 28.21% 28.23% +0.02%
- Complexity 897 906 +9
============================================
Files 231 235 +4
Lines 9326 9443 +117
Branches 1074 1081 +7
============================================
+ Hits 2631 2666 +35
- Misses 6459 6545 +86
+ Partials 236 232 -4
|
Signed-off-by: Subhobrata Dey <[email protected]>
fix flaky tests
sbcd90
requested changes
Jun 22, 2023
|
|
||
| for(Mapping m : mappings) { | ||
| out.writeString(m.getRawField()); | ||
| out.writeString(m.getEcs()); |
There was a problem hiding this comment.
can we use out.writeCollection method here?
|
|
||
| public class LogType implements Writeable, ToXContentObject { | ||
|
|
||
| private static final String ID = "id"; |
There was a problem hiding this comment.
can we add unit tests for this class similar to https://github.com/opensearch-project/common-utils/blob/main/src/test/kotlin/org/opensearch/commons/alerting/model/FindingTests.kt & https://github.com/opensearch-project/common-utils/blob/main/src/test/kotlin/org/opensearch/commons/alerting/model/WriteableTests.kt
| for(String category: ruleCategories){ | ||
| queryBackendMap.put(category, new OSQueryBackend(category, true, true)); | ||
| for(String category: ruleCategories) { | ||
| Map<String, String> fieldMappings = logTypeService.getRuleFieldMappings(category); |
There was a problem hiding this comment.
getRuleFieldMappings internally calls getAllLogTypes from BuiltinLogTypeLoader which internally calls loadBuiltinLogTypes.
Why do we need to load all log types & then filter for particular category in memory?
There was a problem hiding this comment.
Actual loading of logTypes from disk will be done only 1 time. I replaced getAllLogTypes with BuiltinLogTypeLoader.getLogTypeByName(logType) existing method.
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
sbcd90
previously approved these changes
Jun 23, 2023
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
sbcd90
approved these changes
Jul 5, 2023
praveensameneni
approved these changes
Jul 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
* New Log Type JSON format Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]> (cherry picked from commit faccf6c)
sbcd90
pushed a commit
that referenced
this pull request
Jul 11, 2023
* New Log Type JSON format Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]> (cherry picked from commit faccf6c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#459
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.