Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strong password in security test #452

Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jun 1, 2023

Description

[Describe what this change achieves]

Issues Resolved

This change is to accommodate security plugin change opensearch-project/security#2784

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbcd90 sbcd90 marked this pull request as ready for review June 1, 2023 20:58
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #452 (ea803dc) into 2.x (bcd77ca) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #452      +/-   ##
============================================
- Coverage     28.19%   28.18%   -0.02%     
+ Complexity      895      894       -1     
============================================
  Files           231      231              
  Lines          9338     9338              
  Branches       1074     1074              
============================================
- Hits           2633     2632       -1     
  Misses         6469     6469              
- Partials        236      237       +1     

see 1 file with indirect coverage changes

sbcd90
sbcd90 previously approved these changes Jun 1, 2023
@eirsep eirsep changed the base branch from 2.x to main June 1, 2023 22:26
@eirsep eirsep dismissed sbcd90’s stale review June 1, 2023 22:26

The base branch was changed.

@eirsep eirsep changed the base branch from main to 2.x June 1, 2023 22:27
@eirsep
Copy link
Member

eirsep commented Jun 1, 2023

what about main branch??
shouldn't we merge this commit into main and then backport to 2.x

@lezzago lezzago merged commit 99eca77 into opensearch-project:2.x Jun 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 1, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 99eca77)
lezzago pushed a commit that referenced this pull request Jun 1, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 99eca77)

Co-authored-by: bowenlan-amzn <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 99eca77)
sbcd90 pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 99eca77)
sbcd90 pushed a commit that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants