Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle update #437

Merged
merged 11 commits into from
Jun 7, 2023
Merged

Gradle update #437

merged 11 commits into from
Jun 7, 2023

Conversation

petardz
Copy link
Contributor

@petardz petardz commented May 16, 2023

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

petardz added 6 commits May 31, 2023 23:49
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #437 (90b3b0c) into main (65dfd98) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #437      +/-   ##
============================================
- Coverage     28.35%   28.21%   -0.14%     
  Complexity      897      897              
============================================
  Files           231      231              
  Lines          9280     9326      +46     
  Branches       1071     1074       +3     
============================================
  Hits           2631     2631              
- Misses         6413     6459      +46     
  Partials        236      236              
Impacted Files Coverage Δ
...urityanalytics/action/CorrelatedFindingAction.java 0.00% <ø> (ø)
...tyanalytics/action/CreateIndexMappingsRequest.java 46.93% <0.00%> (ø)
...rityanalytics/action/GetIndexMappingsResponse.java 35.71% <0.00%> (ø)
...urityanalytics/action/GetMappingsViewResponse.java 0.00% <0.00%> (ø)
...yanalytics/action/IndexCorrelationRuleRequest.java 0.00% <0.00%> (ø)
...securityanalytics/action/ValidateRulesRequest.java 57.14% <ø> (ø)
...ecurityanalytics/action/ValidateRulesResponse.java 51.61% <0.00%> (ø)
...arch/securityanalytics/correlation/JoinEngine.java 0.00% <0.00%> (ø)
...yanalytics/correlation/VectorEmbeddingsEngine.java 0.00% <0.00%> (ø)
...rrelation/index/query/CorrelationQueryBuilder.java 0.00% <ø> (ø)
... and 8 more

petardz added 3 commits June 2, 2023 00:17
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
sbcd90
sbcd90 previously approved these changes Jun 2, 2023
eirsep
eirsep previously approved these changes Jun 2, 2023
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Petar Dzepina <[email protected]>
@petardz petardz dismissed stale reviews from eirsep and sbcd90 via 90b3b0c June 2, 2023 20:52
@AWSHurneyt
Copy link
Collaborator

@petardz just to clarify, are the windows and security workflows expected to fail at the moment?

@petardz
Copy link
Contributor Author

petardz commented Jun 6, 2023

@petardz just to clarify, are the windows and security workflows expected to fail at the moment?

Yes, windows one failed because older alerting artifact is used during tests, for some reason. For security tests we have another PR which fixes them

build.gradle Show resolved Hide resolved
@sbcd90 sbcd90 merged commit d14e764 into opensearch-project:main Jun 7, 2023
@sbcd90 sbcd90 mentioned this pull request Jul 11, 2023
5 tasks
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* added create dashboard feature

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* creating alias for input indices

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added callout for dashboard creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* disabled test temporarily

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed reference error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants