Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7 bump #387

Merged
merged 4 commits into from
Apr 10, 2023
Merged

2.7 bump #387

merged 4 commits into from
Apr 10, 2023

Conversation

stevanbz
Copy link
Contributor

@stevanbz stevanbz commented Apr 5, 2023

Description

Created 2.7 bump based on the Thomas PR
@sbcd90 - we will need to see how to use the snakeyml SafeConstructor() constructor in QueryBackend and SigmaRule java classes -> here we still have compile errors (since we are using snakeyaml 2.0)
Maybe just:
Yaml yaml = new Yaml(new SafeConstructor(new LoaderOptions()), new Representer(new DumperOptions()), new DumperOptions(), loaderOptions);

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago mentioned this pull request Apr 6, 2023
5 tasks
sbcd90 and others added 2 commits April 6, 2023 03:47
Signed-off-by: Subhobrata Dey <[email protected]>
@stevanbz stevanbz marked this pull request as ready for review April 6, 2023 06:06
@stevanbz stevanbz requested a review from a team April 6, 2023 06:06
@codecov-commenter
Copy link

Codecov Report

Merging #387 (21f2cff) into 2.x (c05fa64) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x     #387   +/-   ##
=========================================
  Coverage     35.76%   35.76%           
  Complexity      885      885           
=========================================
  Files           186      186           
  Lines          7270     7270           
  Branches        878      878           
=========================================
  Hits           2600     2600           
  Misses         4433     4433           
  Partials        237      237           
Impacted Files Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <ø> (ø)
...rch/securityanalytics/action/AckAlertsRequest.java 75.00% <ø> (ø)
...ch/securityanalytics/action/AckAlertsResponse.java 77.27% <ø> (ø)
.../opensearch/securityanalytics/action/AlertDto.java 50.45% <ø> (ø)
...tyanalytics/action/CreateIndexMappingsRequest.java 46.93% <ø> (ø)
...curityanalytics/action/DeleteDetectorResponse.java 0.00% <ø> (ø)
...h/securityanalytics/action/DeleteRuleResponse.java 0.00% <ø> (ø)
...pensearch/securityanalytics/action/FindingDto.java 37.20% <ø> (ø)
...ch/securityanalytics/action/GetAlertsResponse.java 35.29% <ø> (ø)
...analytics/action/GetAllRuleCategoriesResponse.java 0.00% <ø> (ø)
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stevanbz
Copy link
Contributor Author

stevanbz commented Apr 6, 2023

After investigation @sbcd90 and I, we concluded that the security test workflow is failing because the docker image used for secure test doesn't contain alerting plugin 2.7.0 in itself.

@eirsep eirsep merged commit a4cbdff into opensearch-project:2.x Apr 10, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector details shouldn't have a wrapper around the whole page opensearch-project#384

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants