Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds timestamp field alias and sets time range filter in bucket level monitor #262

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jan 10, 2023

  • Adds timestamp field alias mapping for all log types
  • sets time range filter in bucket level monitor creation request when timestamp alias is present

Signed-off-by: Surya Sashank Nistala [email protected]

Description

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested a review from a team January 10, 2023 22:26
@eirsep eirsep force-pushed the time branch 7 times, most recently from db5e6e6 to 4cf4a57 Compare January 11, 2023 02:37
Signed-off-by: Surya Sashank Nistala <[email protected]>
…ge query in bucket monitors

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #262 (89988c3) into main (0dbbbfc) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #262      +/-   ##
============================================
- Coverage     37.10%   36.96%   -0.15%     
  Complexity      887      887              
============================================
  Files           179      179              
  Lines          6982     7010      +28     
  Branches        853      855       +2     
============================================
  Hits           2591     2591              
- Misses         4154     4182      +28     
  Partials        237      237              
Impacted Files Coverage Δ
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
.../opensearch/securityanalytics/util/IndexUtils.java 37.50% <0.00%> (-1.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 78ea8be into opensearch-project:main Jan 11, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-262-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 78ea8be2ffc2d0911ff0f6ba1617871fc68dbdb7
# Push it to GitHub
git push --set-upstream origin backport/backport-262-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-262-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-262-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 78ea8be2ffc2d0911ff0f6ba1617871fc68dbdb7
# Push it to GitHub
git push --set-upstream origin backport/backport-262-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-262-to-2.5.

sbcd90 pushed a commit to sbcd90/security-analytics that referenced this pull request Jan 11, 2023
sbcd90 added a commit that referenced this pull request Jan 11, 2023
…in bucket level monitor (#262) (#279)

Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Surya Sashank Nistala <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
…in bucket level monitor (#262) (#279)

Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 04f3387)
sbcd90 pushed a commit that referenced this pull request Jan 11, 2023
…in bucket level monitor (#262) (#279) (#282)

Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Surya Sashank Nistala <[email protected]>
eirsep added a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
Signed-off-by: Sinisa Andric <[email protected]>

Signed-off-by: Sinisa Andric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants