Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SecureFindingRestApiIT. Removed uppercasing of the detector type #247

Merged

Conversation

stevanbz
Copy link
Contributor

@stevanbz stevanbz commented Jan 6, 2023

Signed-off-by: Stevan Buzejic [email protected]

Description

Fix for SecureFindingRestApiIT -> removed upperCasing without specified locale

Issues Resolved

#246

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stevanbz stevanbz requested a review from a team January 6, 2023 06:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #247 (e0d5067) into main (51a176b) will decrease coverage by 1.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #247      +/-   ##
============================================
- Coverage     38.90%   37.49%   -1.41%     
  Complexity      892      892              
============================================
  Files           176      176              
  Lines          6758     7012     +254     
  Branches        824      878      +54     
============================================
  Hits           2629     2629              
- Misses         3888     4142     +254     
  Partials        241      241              
Impacted Files Coverage Δ
...analytics/transport/TransportDeleteRuleAction.java 0.00% <0.00%> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...ytics/transport/TransportDeleteDetectorAction.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 closed this Jan 7, 2023
@sbcd90 sbcd90 reopened this Jan 9, 2023
@sbcd90 sbcd90 merged commit 8b7f1fd into opensearch-project:main Jan 10, 2023
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* polished UI

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated legend for alert severity

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* use prepend prop for vis group by control

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants