Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetMappingsView API - index pattern/alias/datastream support #245

Merged

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Jan 6, 2023

Description

Added support for index pattern alias and datastreams.

It will return Mappings View of only 1 index depending of what user passed as indexName. In case of Alias/Datastream that would be WriteIndex. In case of index pattern, it would be newest index by creation date.

Issues Resolved

#169
#217

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team January 6, 2023 01:51
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #245 (1626aa8) into main (51a176b) will decrease coverage by 1.05%.
The diff coverage is 25.71%.

@@             Coverage Diff              @@
##               main     #245      +/-   ##
============================================
- Coverage     38.90%   37.84%   -1.06%     
+ Complexity      892      883       -9     
============================================
  Files           176      176              
  Lines          6758     6814      +56     
  Branches        824      834      +10     
============================================
- Hits           2629     2579      -50     
- Misses         3888     3996     +108     
+ Partials        241      239       -2     
Impacted Files Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <0.00%> (ø)
.../transport/TransportCreateIndexMappingsAction.java 0.00% <ø> (ø)
...tics/transport/TransportGetMappingsViewAction.java 0.00% <0.00%> (ø)
.../opensearch/securityanalytics/util/IndexUtils.java 42.18% <0.00%> (-19.18%) ⬇️
...search/securityanalytics/mapper/MapperService.java 17.44% <33.33%> (-16.91%) ⬇️
...ensearch/securityanalytics/mapper/MapperUtils.java 27.94% <100.00%> (-26.23%) ⬇️
...urityanalytics/action/GetMappingsViewResponse.java 0.00% <0.00%> (-13.34%) ⬇️
...rch/securityanalytics/mapper/MapperTopicStore.java 70.37% <0.00%> (-7.41%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sbcd90
sbcd90 previously approved these changes Jan 10, 2023
Signed-off-by: Petar Dzepina <[email protected]>
@sbcd90 sbcd90 merged commit c062cf4 into opensearch-project:main Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
sbcd90 pushed a commit that referenced this pull request Jan 10, 2023
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants