Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky integration tests for security analytics #241

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Jan 5, 2023

Signed-off-by: Subhobrata Dey [email protected]

Description

fix flaky integration tests for security analytics

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbcd90 sbcd90 requested a review from a team January 5, 2023 19:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #241 (44d6ad4) into main (2fcbdba) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #241      +/-   ##
============================================
+ Coverage     38.89%   38.95%   +0.05%     
- Complexity      888      891       +3     
============================================
  Files           176      176              
  Lines          6747     6747              
  Branches        823      823              
============================================
+ Hits           2624     2628       +4     
+ Misses         3880     3877       -3     
+ Partials        243      242       -1     
Impacted Files Coverage Δ
...g/opensearch/securityanalytics/model/Detector.java 70.24% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep
Copy link
Member

eirsep commented Jan 5, 2023

Great find! Thanks for fixing this.

@eirsep eirsep merged commit 95b4f95 into opensearch-project:main Jan 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 5, 2023
Signed-off-by: Subhobrata Dey <[email protected]>

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 95b4f95)
sbcd90 pushed a commit that referenced this pull request Jan 5, 2023
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants