changes to return empty search response for custom rules #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raj Chakravarthi <[email protected]>
raj-chak
changed the title
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
============================================
- Coverage 38.97% 38.96% -0.01%
Complexity 892 892
============================================
Files 176 176
Lines 6746 6747 +1
Branches 823 823
============================================
Hits 2629 2629
- Misses 3876 3877 +1
Partials 241 241
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbcd90
approved these changes
Jan 5, 2023
eirsep
approved these changes
Jan 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Raj Chakravarthi <[email protected]> Signed-off-by: Raj Chakravarthi <[email protected]> (cherry picked from commit 2fcbdba)
sbcd90
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Raj Chakravarthi <[email protected]>
eirsep
pushed a commit
to eirsep/security-analytics
that referenced
this pull request
Apr 3, 2023
…project#231) Signed-off-by: Raj Chakravarthi <[email protected]> Signed-off-by: Raj Chakravarthi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raj Chakravarthi [email protected]
Description
This returns an empty search response (status 200) when there are no custom rules configured instead of throwing an exception. Integration test also written.
Issues Resolved
#205
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.