Feature/191 detector types breaking change #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetFinding supporting multiple detector types GetAlerts supporting multiple detector types Added multiple detector types in request model Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
…dded collection of detector types in input field Refactored tests and updated constructor from a Detector not to consider detector type property Signed-off-by: Stevan Buzejic <[email protected]>
stevanbz
force-pushed
the
feature/191-detector-types-breaking-change
branch
from
5695a9a to
d23de7c
Compare
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
============================================
- Coverage 38.97% 38.58% -0.39%
- Complexity 892 897 +5
============================================
Files 176 176
Lines 6746 6894 +148
Branches 823 844 +21
============================================
+ Hits 2629 2660 +31
- Misses 3876 3988 +112
- Partials 241 246 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stevanbz
force-pushed
the
feature/191-detector-types-breaking-change
branch
2 times, most recently
from
216e8ce to
a59b0cd
Compare
…or detector with multiple detector types Signed-off-by: Stevan Buzejic <[email protected]> Extended alert and finding services to consider multiple detector types Added integration tests Signed-off-by: Stevan Buzejic <[email protected]>
stevanbz
force-pushed
the
feature/191-detector-types-breaking-change
branch
from
5dbd986 to
f43553c
Compare
Signed-off-by: Stevan Buzejic <[email protected]>
5 tasks
|
Closing the PR in favor of: |
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…lyout UI polish (opensearch-project#216) * refactored finding flyout Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> * show surrounding documents when index-pattern available Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed search filter for log source Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added multiple detector types as part of DetectorInput. Extended detector with new field: docLevelMonitorPerCategory used for storing the doc level category:monitorId pairs (used when detector is being updated in order to determine which monitors should be deleted and which query indices should be removed).
In order to support multiple detector types, detectorInput has been extended with List detectorTypes property. To keep the possibility of getting all alerts and findings per detector type and per detector id AlertsService and FindingsService has been extended to use the groupedListener and then they are joining/merging the search alert/finding results.
When updating the detector, if one of the doc level monitor has been deleted by deselecting rules, and the whole rule category has been removed, query index will also be deleted.
Issues Resolved
[191]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.