Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated network mappings #211

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

phaseshiftg
Copy link
Contributor

Signed-off-by: Grant Haywood [email protected]

Description

updated network mappings

Issues Resolved

updated network mappings

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Grant Haywood <[email protected]>
@phaseshiftg phaseshiftg requested a review from a team December 29, 2022 23:04
@eirsep
Copy link
Member

eirsep commented Jan 4, 2023

@phaseshiftg
CI is failing due to failure in below mentioned test plz check
org.opensearch.securityanalytics.resthandler.DetectorMonitorRestApiIT.testReplaceAggregationRuleWithDocRule_verifyFindings_success

@codecov-commenter
Copy link

Codecov Report

Merging #211 (9580756) into main (d5b9b6f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #211   +/-   ##
=========================================
  Coverage     38.87%   38.87%           
  Complexity      887      887           
=========================================
  Files           176      176           
  Lines          6744     6744           
  Branches        823      823           
=========================================
  Hits           2622     2622           
  Misses         3879     3879           
  Partials        243      243           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit d663a79 into opensearch-project:main Jan 4, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2023
Signed-off-by: Grant Haywood <[email protected]>
(cherry picked from commit d663a79)
sbcd90 pushed a commit that referenced this pull request Jan 4, 2023
@cinterloper cinterloper mentioned this pull request Jan 5, 2023
4 tasks
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* removed mac os from unit test platforms

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed redundant command

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants