-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] PR 1142 & PR 1156 #1158
Merged
AWSHurneyt
merged 3 commits into
opensearch-project:2.x
from
AWSHurneyt:2.x-pr1156-backport
Jul 12, 2024
Merged
[Backport 2.x] PR 1142 & PR 1156 #1158
AWSHurneyt
merged 3 commits into
opensearch-project:2.x
from
AWSHurneyt:2.x-pr1156-backport
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds new tif source config type - url download Signed-off-by: Surya Sashank Nistala <[email protected]> * set up create default tif configs Signed-off-by: Surya Sashank Nistala <[email protected]> * address review comments Signed-off-by: Surya Sashank Nistala <[email protected]> * add check to block create and delete operation url download type tif source configs Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
* Removed TODOs. Signed-off-by: AWSHurneyt <[email protected]> * Refactored how STIX2IOCGenerator creates IOCs of specific types. Signed-off-by: AWSHurneyt <[email protected]> * Added additional integration tests. Signed-off-by: AWSHurneyt <[email protected]> * Changed IOCType usage as it's no longer an enum in SA commons. Signed-off-by: AWSHurneyt <[email protected]> * Updated jar file. Signed-off-by: AWSHurneyt <[email protected]> * Fixed unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed tests. Signed-off-by: AWSHurneyt <[email protected]> * Refactored build.gradle to exclude redundant dependencies from SA commons, instead of the SA commons jar being generated withhout those dependencies. Signed-off-by: AWSHurneyt <[email protected]> * Updated jar. Signed-off-by: AWSHurneyt <[email protected]> * Reverted changes to build.gradle. Signed-off-by: AWSHurneyt <[email protected]> * Updated jar. Signed-off-by: AWSHurneyt <[email protected]> * Fixed tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed tests. Signed-off-by: AWSHurneyt <[email protected]> * Fixed IOCType usage. Signed-off-by: AWSHurneyt <[email protected]> * Fixed log message. Signed-off-by: AWSHurneyt <[email protected]> * Fixed tests. Signed-off-by: AWSHurneyt <[email protected]> * Addressed PR feedback. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
July 12, 2024 18:02
eirsep
approved these changes
Jul 12, 2024
jowg-amazon
approved these changes
Jul 12, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.15 2.15
# Navigate to the new working tree
cd .worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-1158-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ff65dc2b0359052503c1a47e0edecc3ea7bb884e
# Push it to GitHub
git push --set-upstream origin backport/backport-1158-to-2.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.15 Then, create a pull request where the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of PRs #1142 and #1156.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.