Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] PR 1142 & PR 1156 #1158

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Manual backport of PRs #1142 and #1156.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

eirsep and others added 3 commits July 12, 2024 10:43
* adds new tif source config type - url download

Signed-off-by: Surya Sashank Nistala <[email protected]>

* set up create default tif configs

Signed-off-by: Surya Sashank Nistala <[email protected]>

* address review comments

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add check to block create and delete operation url download type tif source configs

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
* Removed TODOs.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored how STIX2IOCGenerator creates IOCs of specific types.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional integration tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Changed IOCType usage as it's no longer an enum in SA commons.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated jar file.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed unit tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored build.gradle to exclude redundant dependencies from SA commons, instead of the SA commons jar being generated withhout those dependencies.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated jar.

Signed-off-by: AWSHurneyt <[email protected]>

* Reverted changes to build.gradle.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated jar.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed IOCType usage.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed log message.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Addressed PR feedback.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt AWSHurneyt merged commit ff65dc2 into opensearch-project:2.x Jul 12, 2024
12 of 17 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.15 2.15
# Navigate to the new working tree
cd .worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-1158-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ff65dc2b0359052503c1a47e0edecc3ea7bb884e
# Push it to GitHub
git push --set-upstream origin backport/backport-1158-to-2.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-1158-to-2.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants