-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted IOCTypes usage. #1156
Merged
AWSHurneyt
merged 18 commits into
opensearch-project:main
from
AWSHurneyt:3.0-threat-intel-ioc-types
Jul 12, 2024
Merged
Adjusted IOCTypes usage. #1156
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b0f1311
Removed TODOs.
AWSHurneyt 42a3e2d
Refactored how STIX2IOCGenerator creates IOCs of specific types.
AWSHurneyt 1e1f292
Added additional integration tests.
AWSHurneyt 0003fb4
Changed IOCType usage as it's no longer an enum in SA commons.
AWSHurneyt d03f0ba
Updated jar file.
AWSHurneyt b8dd487
Fixed unit tests.
AWSHurneyt 6d11539
Fixed tests.
AWSHurneyt ad5ea51
Refactored build.gradle to exclude redundant dependencies from SA com…
AWSHurneyt 98bd582
Updated jar.
AWSHurneyt 14112d8
Reverted changes to build.gradle.
AWSHurneyt c2ac444
Updated jar.
AWSHurneyt cbb6b05
Fixed tests.
AWSHurneyt 00053e0
Fixed tests.
AWSHurneyt 26054ac
Fixed tests.
AWSHurneyt 4e59a64
Fixed IOCType usage.
AWSHurneyt 276a890
Fixed log message.
AWSHurneyt f8ead7a
Fixed tests.
AWSHurneyt 1c1e109
Addressed PR feedback.
AWSHurneyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, after changing the IOCTypes from using underscores (e.g.,
domain_name
) to using hyphens (e.g.,domain-name
), it was necessary to append the fields with.keyword
in order for this search request to return results. This change is needed to ensure the potentially-hyphenated values of the fields are being queried as-is.Without these changes, the query returns 0 results despite a
match_all
query confirming there are docs in the concrete index. This was the behavior regardless of whether the index mappings were specified during index creation.