Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dupe findings from group by rules #558

Closed
eirsep opened this issue Sep 8, 2023 · 0 comments
Closed

De-dupe findings from group by rules #558

eirsep opened this issue Sep 8, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers v2.11.0

Comments

@eirsep
Copy link
Member

eirsep commented Sep 8, 2023

Currently bucket level monitor creates findings. These findings are being fed as source data to a match all doc level monitor which again creates duplicate findings. Hence, detector findings have duplicates

one way to tackle this is to avoid fetching findings for the chained findings monitor in search findings api when call is made to alerting plugin to return findings by monitor id

@eirsep eirsep added bug Something isn't working untriaged labels Sep 8, 2023
@praveensameneni praveensameneni added the good first issue Good for newcomers label Sep 14, 2023
@amsiglan amsiglan closed this as completed Oct 5, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Feb 20, 2024
…search-project#558)

* [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review from opensearch-project/security-analytics-dashboards-plugin#558 (comment)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers v2.11.0
Projects
None yet
Development

No branches or pull requests

3 participants