Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Address search request timeouts correctly. #502

Closed
sbcd90 opened this issue Jul 29, 2023 · 1 comment
Closed

[FEATURE] Address search request timeouts correctly. #502

sbcd90 opened this issue Jul 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request v2.11.0

Comments

@sbcd90
Copy link
Collaborator

sbcd90 commented Jul 29, 2023

Is your feature request related to a problem?
Today in our code, we handle SearchRequest timeouts like this,

if (response.isTimedOut()) {
                                            onFailures(new OpenSearchStatusException(String.format(Locale.getDefault(), "Log Type with id %s cannot be updated", logTypeId), RestStatus.INTERNAL_SERVER_ERROR));
                                            return;

What solution would you like?
@lezzago comment

Does this happen often enough? If we are specifically looking for this, we should mention it timed out in the exception. Also this should not be an internal server error since this should be a a transient error that the customer can retry.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@sbcd90 sbcd90 added enhancement New feature or request untriaged labels Jul 29, 2023
@sbcd90 sbcd90 self-assigned this Jul 29, 2023
@sbcd90 sbcd90 removed the untriaged label Jul 29, 2023
@sbcd90
Copy link
Collaborator Author

sbcd90 commented Sep 6, 2023

address comment: #532 (comment)
address comment: #532 (comment)

@lezzago lezzago removed the untriaged label Sep 8, 2023
@amsiglan amsiglan closed this as completed Oct 5, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Feb 20, 2024
* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Feb 20, 2024
* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.11.0
Projects
None yet
Development

No branches or pull requests

3 participants