Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Id field should not be mandatory when creating custom rule #195

Open
amsiglan opened this issue Dec 13, 2022 · 2 comments
Open

[FEATURE] Id field should not be mandatory when creating custom rule #195

amsiglan opened this issue Dec 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@amsiglan
Copy link
Collaborator

Is your feature request related to a problem?
In the create rule API, Id field is required as part of feature payload. User shouldn't have to pass this.

What solution would you like?
The Id field should be dropped from the requirement

What alternatives have you considered?
N/A

Do you have any additional context?
Screen Shot 2022-12-13 at 11 16 52 AM
@amsiglan amsiglan added enhancement New feature or request untriaged labels Dec 13, 2022
@getsaurabh02 getsaurabh02 added the v2.5.0 2.5.0 release label Dec 13, 2022
@sbcd90
Copy link
Collaborator

sbcd90 commented Jan 6, 2023

@raj-chak assigned to you

@raj-chak raj-chak mentioned this issue Jan 23, 2023
Closed
5 tasks
@raj-chak
Copy link
Contributor

raj-chak commented Feb 7, 2023

Pull Request:

@praveensameneni praveensameneni removed the v2.5.0 2.5.0 release label Mar 9, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Feb 20, 2024
@jovancvetkovic3006
Feature/detector navigation to findings and alerts opensearch-project…
d412ea6 
…#195 (opensearch-project#210)

* [FEATURE] Navigate from the Detector page to Alerts/Findings filtered by the detector opensearch-project#195

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Navigate from the Detector page to Alerts/Findings filtered by the detector opensearch-project#195

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Navigate from the Detector page to Alerts/Findings filtered by the detector opensearch-project#195

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Fixing jest tests for helper utilities

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature/detector navigation to findings and alerts opensearch-project#195 opensearch-project#210

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sbcd90 @getsaurabh02 @raj-chak @praveensameneni @amsiglan