Skip to content

Commit

Permalink
fix integ tests for findings api
Browse files Browse the repository at this point in the history
Signed-off-by: Joanne Wang <[email protected]>
  • Loading branch information
jowg-amazon committed Mar 15, 2024
1 parent 910d73b commit 5c75320
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public void testGetAllFindings_success() throws IOException {
Map<String, String> params = new HashMap<>();
Response getFindingsResponse = makeRequest(client(), "GET", SecurityAnalyticsPlugin.FINDINGS_BASE_URI + "/_search", params, null);
Map<String, Object> getFindingsBody = entityAsMap(getFindingsResponse);
Assert.assertEquals(1, getFindingsBody.get("total_findings"));
Assert.assertEquals(2, getFindingsBody.get("total_findings"));
}

public void testGetFindings_byDetectionType_success() throws IOException {
Expand Down Expand Up @@ -589,13 +589,13 @@ public void testGetFindings_bySeverity_success() throws IOException {
params.put("severity", "high");
Response getFindingsResponse = makeRequest(client(), "GET", SecurityAnalyticsPlugin.FINDINGS_BASE_URI + "/_search", params, null);
Map<String, Object> getFindingsBody = entityAsMap(getFindingsResponse);
Assert.assertEquals(1, getFindingsBody.get("total_findings"));
Assert.assertEquals(2, getFindingsBody.get("total_findings"));
// Call GetFindings API for second detector by severity
params.clear();
params.put("severity", "critical");
getFindingsResponse = makeRequest(client(), "GET", SecurityAnalyticsPlugin.FINDINGS_BASE_URI + "/_search", params, null);
getFindingsBody = entityAsMap(getFindingsResponse);
Assert.assertEquals(1, getFindingsBody.get("total_findings"));
Assert.assertEquals(2, getFindingsBody.get("total_findings"));
}

public void testGetFindings_bySearchString_success() throws IOException {
Expand Down Expand Up @@ -842,7 +842,7 @@ public void testGetFindings_byStartTimeAndEndTime_success() throws IOException {
params.put("endTime", String.valueOf(endTime2.toEpochMilli()));
getFindingsResponse = makeRequest(client(), "GET", SecurityAnalyticsPlugin.FINDINGS_BASE_URI + "/_search", params, null);
getFindingsBody = entityAsMap(getFindingsResponse);
Assert.assertEquals(1, getFindingsBody.get("total_findings"));
Assert.assertEquals(2, getFindingsBody.get("total_findings"));
}

public void testGetFindings_rolloverByMaxAge_success() throws IOException, InterruptedException {
Expand Down

0 comments on commit 5c75320

Please sign in to comment.