[Detector creation] UI workflow metrics #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
- Coverage 31.03% 31.00% -0.03%
==========================================
Files 151 157 +6
Lines 5111 5179 +68
Branches 948 906 -42
==========================================
+ Hits 1586 1606 +20
- Misses 3335 3386 +51
+ Partials 190 187 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
AWSHurneyt
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
@amsiglan said offline that the cypress tests are passing locally. Changes LGTM.
| import { MetricsCounter, PartialMetricsCounter } from '../types'; | ||
| import { SecurityAnalyticsPluginConfigType } from '../config'; | ||
|
|
||
| export function aggregateMetrics( |
There was a problem hiding this comment.
Nitpick: Some comments explaining these functions would be helpful.
Signed-off-by: Amardeepsingh Siglani <[email protected]>
sbcd90
approved these changes
Feb 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* implemented metrics for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * added config based flag; interval of 2 min to emit browser metrics Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused metrics counters Signed-off-by: Amardeepsingh Siglani <[email protected]> * added null check Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated code to check for window unload Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit dff1ef3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Feb 6, 2024
* implemented metrics for detector creation * updated tests * added config based flag; interval of 2 min to emit browser metrics * removed unused metrics counters * added null check * updated code to check for window unload --------- (cherry picked from commit dff1ef3) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding metrics to understand detector creation hurdles in the UI.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.