-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache date time filter in local storage #848
Cache date time filter in local storage #848
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
+ Coverage 31.02% 31.04% +0.01%
==========================================
Files 157 157
Lines 5202 5206 +4
Branches 918 919 +1
==========================================
+ Hits 1614 1616 +2
- Misses 3401 3403 +2
Partials 187 187 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The windows cypress tests are known to be flaky with timeout issues. Rerunning those tests, and approving.
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Similar to PR #864, the |
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit a7c7eef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.6 2.6
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.6
# Create a new branch
git switch --create backport-848-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7c7eef809dc870d207dffba16dbd1b45a4a542c
# Push it to GitHub
git push --set-upstream origin backport-848-to-2.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.6 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.7
# Create a new branch
git switch --create backport-848-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7c7eef809dc870d207dffba16dbd1b45a4a542c
# Push it to GitHub
git push --set-upstream origin backport-848-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.7 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.8
# Create a new branch
git switch --create backport-848-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7c7eef809dc870d207dffba16dbd1b45a4a542c
# Push it to GitHub
git push --set-upstream origin backport-848-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.8 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.9
# Create a new branch
git switch --create backport-848-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7c7eef809dc870d207dffba16dbd1b45a4a542c
# Push it to GitHub
git push --set-upstream origin backport-848-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.9 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.10
# Create a new branch
git switch --create backport-848-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7c7eef809dc870d207dffba16dbd1b45a4a542c
# Push it to GitHub
git push --set-upstream origin backport-848-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.10 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-848-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7c7eef809dc870d207dffba16dbd1b45a4a542c
# Push it to GitHub
git push --set-upstream origin backport-848-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 Then, create a pull request where the |
(cherry picked from commit a7c7eef) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This change caches the date time filter set on various pages so that on page refresh we remember it.
Issues Resolved
#731
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.