-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threat intel feed support for detector creation #762
Threat intel feed support for detector creation #762
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 33.01% 31.18% -1.84%
==========================================
Files 150 151 +1
Lines 4916 4977 +61
Branches 881 900 +19
==========================================
- Hits 1623 1552 -71
- Misses 3188 3236 +48
- Partials 105 189 +84 |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
.../CreateDetector/components/ConfigureAlerts/components/AlertCondition/AlertConditionPanel.tsx
Show resolved
Hide resolved
.../CreateDetector/components/ConfigureAlerts/components/AlertCondition/AlertConditionPanel.tsx
Show resolved
Hide resolved
.../CreateDetector/components/ConfigureAlerts/components/AlertCondition/AlertConditionPanel.tsx
Show resolved
Hide resolved
...reateDetector/components/DefineDetector/components/ThreatIntelligence/ThreatIntelligence.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a backend bug that's causing the cypress workflow that fails.
https://github.com/opensearch-project/security-analytics-dashboards-plugin/actions/runs/6591385207/job/17909859712?pr=762#step:6:69
Approving this PR for now as I know there are followup PRs coming.
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-762-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f92126cc81c4e9352eb5daa04589a8cbc780de8
# Push it to GitHub
git push --set-upstream origin backport/backport-762-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-762-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f92126cc81c4e9352eb5daa04589a8cbc780de8
# Push it to GitHub
git push --set-upstream origin backport/backport-762-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11 Then, create a pull request where the |
* added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* added threat intel feed support for detector creation * updated cypress workflow file * updated alerts; findings UX * refactored alert condition panel; update detector for intel feeds * updated snapshots, mocks * updated workflow * updated tests * updated snapshot * updated UI; tests --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
…roject#762) (opensearch-project#769)" This reverts commit 64982b9. Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Revert "Make notifications optional 2.11 (#770)" This reverts commit de6001a. Signed-off-by: Amardeepsingh Siglani <[email protected]> * Revert "Threat intel feed support for detector creation (#762) (#769)" This reverts commit 64982b9. Signed-off-by: Amardeepsingh Siglani <[email protected]> * Revert "[Backport 2.11] Improved display of log types. (#766)" This reverts commit 25901f6. Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* added threat intel feed support for detector creation * updated cypress workflow file * updated alerts; findings UX * refactored alert condition panel; update detector for intel feeds * updated snapshots, mocks * updated workflow * updated tests * updated snapshot * updated UI; tests --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional 2.11 (opensearch-project#770) * Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional (#796) * Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * supporting array of key/value under selection (#803) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Correlation rules field matching and time window support (#804) * added ux for group by field and time window Signed-off-by: Amardeepsingh Siglani <[email protected]> * improved validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * check for null values Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * validate fields only when group by enabled; update default window to 5 min (#810) Signed-off-by: Amardeepsingh Siglani <[email protected]> * do not send fields if empty (#817) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Allow empty field name for supporting timeframe and keywords when validating rule during creation/update (#823) * allow empty field name for supporting timeframe and keywords Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed update payload (#838) Signed-off-by: Amardeepsingh Siglani <[email protected]> * add already mapped log index fields to list of options (#845) Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional 2.11 (opensearch-project#770) * Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* Make notifications optional (#796) * Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert notification change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * supporting array of key/value under selection (#803) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Correlation rules field matching and time window support (#804) * added ux for group by field and time window Signed-off-by: Amardeepsingh Siglani <[email protected]> * improved validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * check for null values Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * validate fields only when group by enabled; update default window to 5 min (#810) Signed-off-by: Amardeepsingh Siglani <[email protected]> * do not send fields if empty (#817) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Allow empty field name for supporting timeframe and keywords when validating rule during creation/update (#823) * allow empty field name for supporting timeframe and keywords Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed update payload (#838) Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Description
This PR implements the changes to the detector creation workflow outlines in the issue #760 which will allow users to enable or opt-out of threat intel feed based detection.
Issues Resolved
Partially implements #760
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.