Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance log type filters correlations #745

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Oct 6, 2023

Description

Log type filter in the correlations page makes use of the new log categories and also allows group selection/deselction

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #745 (5d7d424) into main (3ce112b) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 5d7d424 differs from pull request most recent head cefe48a. Consider uploading reports for the commit cefe48a to get more accurate results

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   31.46%   31.28%   -0.18%     
==========================================
  Files         150      150              
  Lines        4882     4913      +31     
  Branches      876      880       +4     
==========================================
+ Hits         1536     1537       +1     
- Misses       3162     3192      +30     
  Partials      184      184              

see 9 files with indirect coverage changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan added backport 2.x backport 2.11 PRs to be backported to 2.11 branch labels Oct 6, 2023
@amsiglan amsiglan merged commit b581e58 into opensearch-project:main Oct 6, 2023
8 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed typo

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit b581e58)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed typo

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit b581e58)
amsiglan added a commit that referenced this pull request Oct 6, 2023
* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed typo

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit b581e58)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Oct 6, 2023
* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated log type filters; fixed search field

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed typo

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit b581e58)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.11 PRs to be backported to 2.11 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants