-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance log type filters correlations #745
Merged
amsiglan
merged 3 commits into
opensearch-project:main
from
amsiglan:log-type-filters-correlations
Oct 6, 2023
Merged
Enhance log type filters correlations #745
amsiglan
merged 3 commits into
opensearch-project:main
from
amsiglan:log-type-filters-correlations
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
October 6, 2023 00:28
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 31.46% 31.28% -0.18%
==========================================
Files 150 150
Lines 4882 4913 +31
Branches 876 880 +4
==========================================
+ Hits 1536 1537 +1
- Misses 3162 3192 +30
Partials 184 184 |
AWSHurneyt
approved these changes
Oct 6, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
eirsep
approved these changes
Oct 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed typo Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b581e58)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed typo Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b581e58)
amsiglan
added a commit
that referenced
this pull request
Oct 6, 2023
* updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed typo Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b581e58) Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Oct 6, 2023
* updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed typo Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b581e58) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log type filter in the correlations page makes use of the new log categories and also allows group selection/deselction
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.