Added categories for log types #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
AWSHurneyt
approved these changes
Oct 5, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 31.49% 31.46% -0.04%
==========================================
Files 149 150 +1
Lines 4826 4882 +56
Branches 867 876 +9
==========================================
+ Hits 1520 1536 +16
- Misses 3123 3162 +39
- Partials 183 184 +1 |
|
The test failures are due to lack of log type categories in the 2.9 SA backend. Tests passed locally 
|
lezzago
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* added categories for log types Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 3ce112b)
amsiglan
added a commit
that referenced
this pull request
Oct 5, 2023
* added categories for log types Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 3ce112b) Co-authored-by: Amardeepsingh Siglani <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* added categories for log types Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 3ce112b)
amsiglan
added a commit
that referenced
this pull request
Oct 6, 2023
* added categories for log types Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 3ce112b) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added categories for log types which would make it easier for users to search, use log types throughout the plugin workflows
Issues Resolved
#736
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.