Simplify detector creation UX #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
…tion-enhancements-pt-2
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 31.48% 31.49%
=======================================
Files 150 149 -1
Lines 4818 4826 +8
Branches 858 867 +9
=======================================
+ Hits 1517 1520 +3
- Misses 3122 3123 +1
- Partials 179 183 +4 |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
lezzago
approved these changes
Oct 4, 2023
AWSHurneyt
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
* removed review page; enhanced alerts page Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated trigger details subheading to use selected data Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated define detector, overview pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * reverting cypress workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated field mapping texts Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 8a7bf7d)
amsiglan
changed the title
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 4, 2023
* removed review page; enhanced alerts page Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated trigger details subheading to use selected data Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated define detector, overview pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * reverting cypress workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated field mapping texts Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 8a7bf7d) Co-authored-by: Amardeepsingh Siglani <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplified detector creation workflow by:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.