Added check for empty action #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
lezzago
approved these changes
Sep 7, 2023
AWSHurneyt
approved these changes
Sep 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 31.48% 31.50% +0.02%
==========================================
Files 150 150
Lines 4812 4812
Branches 802 802
==========================================
+ Hits 1515 1516 +1
+ Misses 3118 3117 -1
Partials 179 179 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 2e94054)
This was referenced Sep 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 2e94054)
amsiglan
added a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 2e94054) Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 2e94054) Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Mar 16, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 2e94054) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user creates a detector without action using APIs, UX fails to render the detector correctly. This PR adds a check for empty action and renders a default empty state.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.