-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CIDR modifier for detection fields #693
Added CIDR modifier for detection fields #693
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 31.27% 31.30% +0.02%
==========================================
Files 150 150
Lines 4787 4789 +2
Branches 790 792 +2
==========================================
+ Hits 1497 1499 +2
Misses 3112 3112
Partials 178 178 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress workflow failed because the backend plugin failed to start (link).
…fier-in-detection
Failed test is unrelated to the change in this PR |
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7e5985f)
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7e5985f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7e5985f)
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7e5985f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-693-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e5985fbdeed097f545cede1ffd0b2a5710271d2
# Push it to GitHub
git push --set-upstream origin backport/backport-693-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10 Then, create a pull request where the |
Description
To provide IP ranges in the detection fields of a rule, we need to support the cidr modifier option. This PR adds that option in the dropdown. It also fixes a couple of edge cases for detection parsing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.