UI polish for correlations and custom log types #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
sbcd90
approved these changes
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #683 +/- ##
=======================================
Coverage 31.35% 31.35%
=======================================
Files 150 150
Lines 4759 4762 +3
Branches 783 786 +3
=======================================
+ Hits 1492 1493 +1
- Misses 3089 3091 +2
Partials 178 178 |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
approved these changes
Aug 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
* fixed abbreviations Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed log type name validation Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b54bb36)
amsiglan
added a commit
that referenced
this pull request
Aug 2, 2023
* fixed abbreviations Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed log type name validation Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b54bb36) Co-authored-by: Amardeepsingh Siglani <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
* fixed abbreviations Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed log type name validation Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b54bb36)
amsiglan
added a commit
that referenced
this pull request
Aug 3, 2023
* fixed abbreviations Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed log type name validation Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b54bb36) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…) (opensearch-project#685) * fixed abbreviations Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed log type name validation Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit b54bb36) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.