Pass sortOrder and size params when getting findings and alerts #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
=======================================
Coverage 32.53% 32.53%
=======================================
Files 138 138
Lines 4525 4525
Branches 748 748
=======================================
Hits 1472 1472
Misses 2876 2876
Partials 177 177 |
AWSHurneyt
approved these changes
Jul 24, 2023
sbcd90
approved these changes
Jul 24, 2023
AWSHurneyt
added
backport 2.x
backport 2.5
backport 2.6
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f)
This was referenced Jul 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f)
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Aug 25, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Aug 25, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ct#671) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Nov 21, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Nov 21, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 15f2e2f) Co-authored-by: Amardeepsingh Siglani <[email protected]> cr: https://code.amazon.com/reviews/CR-97337837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to get all alerts and findings for a detector, so we are passing a high default number for size and sorting them in descending order by timestamp
Issues Resolved
#664
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.