-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for editing correlation rule #643
Merged
amsiglan
merged 4 commits into
opensearch-project:main
from
amsiglan:correlation-rules-edit-view-support
Jul 12, 2023
Merged
Added support for editing correlation rule #643
amsiglan
merged 4 commits into
opensearch-project:main
from
amsiglan:correlation-rules-edit-view-support
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
July 12, 2023 00:43
lezzago
reviewed
Jul 12, 2023
lezzago
reviewed
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 32.66% 32.51% -0.15%
==========================================
Files 139 139
Lines 4491 4527 +36
Branches 803 748 -55
==========================================
+ Hits 1467 1472 +5
- Misses 2847 2878 +31
Partials 177 177 |
lezzago
reviewed
Jul 12, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
lezzago
approved these changes
Jul 12, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
sbcd90
approved these changes
Jul 12, 2023
AWSHurneyt
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* added support for editing correlation rule Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed query deletion; api method Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed logs Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed rule expression builder Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0fee0e8)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-643-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0fee0e803653a555ad5b8d4fdb910266ba9f6097
# Push it to GitHub
git push --set-upstream origin backport/backport-643-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9 Then, create a pull request where the |
amsiglan
added a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Jul 12, 2023
* added support for editing correlation rule Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed query deletion; api method Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed logs Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed rule expression builder Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
1 task
amsiglan
added a commit
that referenced
this pull request
Jul 12, 2023
* added support for editing correlation rule * fixed query deletion; api method * removed logs * fixed rule expression builder --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Jul 12, 2023
* added support for editing correlation rule Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed query deletion; api method Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed logs Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed rule expression builder Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 0fee0e8) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…pensearch-project#646) * added support for editing correlation rule * fixed query deletion; api method * removed logs * fixed rule expression builder --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for editing a correlation rule
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.