Custom rules multiply on the create detector page after switching log types #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types opensearch-project#624 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into Custom_rules_multiply_on_the_Create_Detector_page_after_switching_Log_types
… types opensearch-project#624 Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
|
@amsiglan backport to 2.x, 2.7 and 2.8 |
amsiglan
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 31.48% 31.48%
=======================================
Files 138 138
Lines 4335 4335
Branches 771 721 -50
=======================================
Hits 1365 1365
Misses 2832 2832
Partials 138 138 |
AWSHurneyt
approved these changes
Jun 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
… types (#625) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
… types (#625) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
… types (#625) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e)
AWSHurneyt
added a commit
that referenced
this pull request
Jun 8, 2023
…r switching log types (#627) * Custom rules multiply on the create detector page after switching log types (#625) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e) * Updated dependency references in test workflows. Signed-off-by: AWSHurneyt <[email protected]> * Updated dependency references in test workflows. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Co-authored-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Jun 12, 2023
… types (#625) (#628) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e) Co-authored-by: Jovan Cvetkovic <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Jun 12, 2023
… types (#625) (#626) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
… types (opensearch-project#625) (opensearch-project#626) * Custom rules multiply on the Create Detector page after switching Log types opensearch-project#624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types opensearch-project#624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
… types (#625) (#626) * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> * Custom rules multiply on the Create Detector page after switching Log types #624 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit db0354e) Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom rules multiply on the create detector page after switching log types
Issues Resolved
Resolves #624
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.