[Backport 2.x] Backporting several PRs to 2.x that failed the DCO check. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2022
phestecAMZN
approved these changes
Nov 4, 2022
amsiglan
approved these changes
Nov 4, 2022
Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
* shared utils, interfaces, client services Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated visualization code to use security compliant parsing Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
* merged latest Overview page Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
… analytics backend plugin (opensearch-project#36) * added/updated service wrappers Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
* updated create detector ux Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
* rewrote rules pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted changed Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
…red some components based on feedback. (opensearch-project#56) * Refactored display text on flyout accordions based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector field mapping edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector rule edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections. Signed-off-by: AWSHurneyt <[email protected]> * Refactor flyout to have links to detector details and rules pages. Signed-off-by: AWSHurneyt <[email protected]> * Implemented toast notifications for failed and successful API calls. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
…ck. (#57) * Add unit test CI (#34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Adding shared utils, interfaces, client services (#35) * shared utils, interfaces, client services Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated visualization code to use security compliant parsing Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Overview UI page updates (#37) * merged latest Overview page Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36) * added/updated service wrappers Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Updated create detector UX (#39) * updated create detector ux Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * added detectors view/edit ux (#40) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated main and rules pages (#41) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated alerts and findings UI pages (#38) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Rules refactor (#55) * rewrote rules pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted changed Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56) * Refactored display text on flyout accordions based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector field mapping edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector rule edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections. Signed-off-by: AWSHurneyt <[email protected]> * Refactor flyout to have links to detector details and rules pages. Signed-off-by: AWSHurneyt <[email protected]> * Implemented toast notifications for failed and successful API calls. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * fixedimport issues (#58) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> (cherry picked from commit 674ff1c)
phestecAMZN
pushed a commit
that referenced
this pull request
Nov 4, 2022
…ck. (#57) (#63) * Add unit test CI (#34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Adding shared utils, interfaces, client services (#35) * shared utils, interfaces, client services Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated visualization code to use security compliant parsing Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Overview UI page updates (#37) * merged latest Overview page Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36) * added/updated service wrappers Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Updated create detector UX (#39) * updated create detector ux Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * added detectors view/edit ux (#40) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated main and rules pages (#41) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated alerts and findings UI pages (#38) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Rules refactor (#55) * rewrote rules pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted changed Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56) * Refactored display text on flyout accordions based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector field mapping edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector rule edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections. Signed-off-by: AWSHurneyt <[email protected]> * Refactor flyout to have links to detector details and rules pages. Signed-off-by: AWSHurneyt <[email protected]> * Implemented toast notifications for failed and successful API calls. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * fixedimport issues (#58) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> (cherry picked from commit 674ff1c) Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
that referenced
this pull request
Nov 4, 2022
…ck. (#68) * Add unit test CI (#34) (#42) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit d05c238) Co-authored-by: bowenlan-amzn <[email protected]> * [Backport 2.x] Backporting several PRs to 2.x that failed the DCO check. (#57) * Add unit test CI (#34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Adding shared utils, interfaces, client services (#35) * shared utils, interfaces, client services Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated visualization code to use security compliant parsing Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Overview UI page updates (#37) * merged latest Overview page Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36) * added/updated service wrappers Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Updated create detector UX (#39) * updated create detector ux Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * added detectors view/edit ux (#40) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated main and rules pages (#41) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated alerts and findings UI pages (#38) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Rules refactor (#55) * rewrote rules pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted changed Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56) * Refactored display text on flyout accordions based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector field mapping edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector rule edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections. Signed-off-by: AWSHurneyt <[email protected]> * Refactor flyout to have links to detector details and rules pages. Signed-off-by: AWSHurneyt <[email protected]> * Implemented toast notifications for failed and successful API calls. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * fixedimport issues (#58) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> * Drafted 2.4 release notes. (#65) (#66) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit a985878) Co-authored-by: AWSHurneyt <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Co-authored-by: Amardeepsingh <[email protected]>
1 task
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…ck. (opensearch-project#57) * Add unit test CI (opensearch-project#34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Adding shared utils, interfaces, client services (opensearch-project#35) * shared utils, interfaces, client services Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated visualization code to use security compliant parsing Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Overview UI page updates (opensearch-project#37) * merged latest Overview page Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added/updated service wrappers used for making REST calls to security analytics backend plugin (opensearch-project#36) * added/updated service wrappers Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Updated create detector UX (opensearch-project#39) * updated create detector ux Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * added detectors view/edit ux (opensearch-project#40) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated main and rules pages (opensearch-project#41) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated alerts and findings UI pages (opensearch-project#38) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Rules refactor (opensearch-project#55) * rewrote rules pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted changed Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (opensearch-project#56) * Refactored display text on flyout accordions based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector field mapping edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector rule edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections. Signed-off-by: AWSHurneyt <[email protected]> * Refactor flyout to have links to detector details and rules pages. Signed-off-by: AWSHurneyt <[email protected]> * Implemented toast notifications for failed and successful API calls. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * fixedimport issues (opensearch-project#58) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ck. (opensearch-project#57) * Add unit test CI (opensearch-project#34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Adding shared utils, interfaces, client services (opensearch-project#35) * shared utils, interfaces, client services Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated visualization code to use security compliant parsing Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Overview UI page updates (opensearch-project#37) * merged latest Overview page Signed-off-by: Amardeepsingh Siglani <[email protected]> * minor refactor Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added/updated service wrappers used for making REST calls to security analytics backend plugin (opensearch-project#36) * added/updated service wrappers Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Updated create detector UX (opensearch-project#39) * updated create detector ux Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused code Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * added detectors view/edit ux (opensearch-project#40) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated main and rules pages (opensearch-project#41) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * updated alerts and findings UI pages (opensearch-project#38) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Rules refactor (opensearch-project#55) * rewrote rules pages Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted changed Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (opensearch-project#56) * Refactored display text on flyout accordions based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector field mapping edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug that caused the detector rule edit page to crash on refresh. Signed-off-by: AWSHurneyt <[email protected]> * Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections. Signed-off-by: AWSHurneyt <[email protected]> * Refactor flyout to have links to detector details and rules pages. Signed-off-by: AWSHurneyt <[email protected]> * Implemented toast notifications for failed and successful API calls. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * fixedimport issues (opensearch-project#58) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Co-authored-by: Amardeepsingh <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closing the following failed 2.x backport PRs.
#43
#45
#47
#49
#51
#53
Also closing the following failed 2.4 backport PRs in favor of the backport from this PR.
#44
#46
#48
#50
#52
#54
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.