-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create detector refactor alert triggers per mocks #503
Create detector refactor alert triggers per mocks #503
Conversation
…the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]>
…oject#493 Signed-off-by: Jovan Cvetkovic <[email protected]>
…rch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]>
…rch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]>
…rch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 35.58% 35.55% -0.04%
==========================================
Files 121 121
Lines 3428 3440 +12
Branches 596 601 +5
==========================================
+ Hits 1220 1223 +3
- Misses 2073 2081 +8
- Partials 135 136 +1 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…-analytics-dashboards-plugin into Create_detector_Refactor_alert_triggers_per_mocks_#498 # Conflicts: # public/pages/CreateDetector/utils/constants.ts
public/pages/CreateDetector/components/ConfigureAlerts/containers/ConfigureAlerts.tsx
Outdated
Show resolved
Hide resolved
…-analytics-dashboards-plugin into Create_detector_Refactor_alert_triggers_per_mocks_#498
opensearch-project#503 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into Create_detector_Refactor_alert_triggers_per_mocks_#498 # Conflicts: # cypress/integration/1_detectors.spec.js
Signed-off-by: Jovan Cvetkovic <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-503-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cb8c0a0757e1ce05f624d284e613c74948f884ce
# Push it to GitHub
git push --set-upstream origin backport/backport-503-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…#503) * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]> * Create detector refactor alert triggers per mocks opensearch-project#503 Signed-off-by: Jovan Cvetkovic <[email protected]> * Update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 * [FEATURE] Create global state object for async requests #493 * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 * Create detector refactor alert triggers per mocks #503 * Update detector details component #504 --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]>
…#503) (opensearch-project#514) * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 * [FEATURE] Create global state object for async requests opensearch-project#493 * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 * Create detector refactor alert triggers per mocks opensearch-project#503 * Update detector details component opensearch-project#504 --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Description
Implements new mocks for alert triggers during the detector creation process.
Issues Resolved
Resolves #498
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.