-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communicate to users when the detector is initializing #487
Merged
amsiglan
merged 15 commits into
opensearch-project:main
from
jovancacvetkovic:detector_is_initializing_banner
Mar 23, 2023
Merged
Communicate to users when the detector is initializing #487
amsiglan
merged 15 commits into
opensearch-project:main
from
jovancacvetkovic:detector_is_initializing_banner
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into detector_is_initializing_banner
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into detector_is_initializing_banner
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into detector_is_initializing_banner # Conflicts: # public/pages/CreateDetector/containers/CreateDetector.tsx
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ject#487 Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me; only a minor comment. I believe you mentioned offline that you plan to include some other changes in this PR, so I'll hold off on approving for now.
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this pull request
Mar 17, 2023
…ject#487 Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
approved these changes
Mar 22, 2023
amsiglan
approved these changes
Mar 23, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
* [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * Common data store for the rules #474 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing #487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 068d03e)
AWSHurneyt
pushed a commit
that referenced
this pull request
Mar 31, 2023
* [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * Common data store for the rules #474 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing #227 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing #487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 068d03e) Co-authored-by: Jovan Cvetkovic <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing #487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing #487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit bb277ae)
amsiglan
pushed a commit
that referenced
this pull request
Apr 6, 2023
* Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing #487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates #482 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit bb277ae) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…oject#487) (opensearch-project#492) * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing opensearch-project#487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 068d03e) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…pensearch-project#500) * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Communicate to users when the detector is initializing opensearch-project#487 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> * Edit detector - UX improvements and updates opensearch-project#482 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit bb277ae) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[FEATURE] Communicate to users when the detector is initializing
Issues Resolved
Resolves #227
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.