Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicate to users when the detector is initializing #487

Conversation

jovancacvetkovic
Copy link

@jovancacvetkovic jovancacvetkovic commented Mar 16, 2023

Description

[FEATURE] Communicate to users when the detector is initializing

Issues Resolved

Resolves #227

Screenshots

detector initializing
detector failed
detector created

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-analytics-dashboards-plugin into detector_is_initializing_banner

# Conflicts:
#	public/pages/CreateDetector/containers/CreateDetector.tsx
@jovancacvetkovic jovancacvetkovic requested a review from a team March 16, 2023 17:42
Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me; only a minor comment. I believe you mentioned offline that you plan to include some other changes in this PR, so I'll hold off on approving for now.

public/pages/CreateDetector/containers/CreateDetector.tsx Outdated Show resolved Hide resolved
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this pull request Mar 17, 2023
Signed-off-by: Jovan Cvetkovic <[email protected]>
@amsiglan amsiglan merged commit 068d03e into opensearch-project:main Mar 23, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2023
* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Common data store for the rules #474

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 068d03e)
AWSHurneyt pushed a commit that referenced this pull request Mar 31, 2023
* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Common data store for the rules #474

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing #227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 068d03e)

Co-authored-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit that referenced this pull request Apr 4, 2023
* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 4, 2023
* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit bb277ae)
amsiglan pushed a commit that referenced this pull request Apr 6, 2023
* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing #487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates #482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit bb277ae)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…oject#487) (opensearch-project#492)

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Common data store for the rules opensearch-project#474

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Communicate to users when detector is initializing opensearch-project#227

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing opensearch-project#487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 068d03e)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…pensearch-project#500)

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Communicate to users when the detector is initializing opensearch-project#487

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Edit detector - UX improvements and updates opensearch-project#482

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit bb277ae)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Communicate to users when detector is initializing
4 participants