Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix Node.js and Yarn installation in CI #451

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Manually backporting PR #446 to fix DCO issue.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt AWSHurneyt added the backport 2.6 Used for marking changes that must be merged into 2.6 branch label Feb 22, 2023
@AWSHurneyt AWSHurneyt changed the base branch from main to 2.x February 22, 2023 06:10
@AWSHurneyt AWSHurneyt marked this pull request as ready for review February 22, 2023 06:20
@AWSHurneyt AWSHurneyt requested a review from a team February 22, 2023 06:20
@AWSHurneyt AWSHurneyt changed the title Pr446 backport [Backport 2.x] Fix Node.js and Yarn installation in CI Feb 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #451 (e1bd876) into 2.x (ec2e438) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e1bd876 differs from pull request most recent head da7f386. Consider uploading reports for the commit da7f386 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x     #451      +/-   ##
==========================================
+ Coverage   34.96%   34.97%   +0.01%     
==========================================
  Files         112      112              
  Lines        3109     3108       -1     
  Branches      488      489       +1     
==========================================
  Hits         1087     1087              
+ Misses       1908     1907       -1     
  Partials      114      114              
Impacted Files Coverage Δ
...nents/DefineDetector/containers/DefineDetector.tsx 2.50% <0.00%> (-10.74%) ⬇️
...tors/containers/FieldMappings/EditFieldMapping.tsx 54.54% <0.00%> (-1.02%) ⬇️
...oards-plugin/public/pages/Rules/utils/constants.ts 100.00% <0.00%> (ø)
...mponents/UpdateBasicDetails/UpdateBasicDetails.tsx 50.76% <0.00%> (ø)
...eFieldMapping/containers/ConfigureFieldMapping.tsx 13.79% <0.00%> (ø)
...mponents/DetectorDataSource/DetectorDataSource.tsx 17.24% <0.00%> (+10.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AWSHurneyt AWSHurneyt merged commit 633a37a into opensearch-project:2.x Feb 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Miki <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit 633a37a)
amsiglan pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Miki <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit 633a37a)

Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.6 Used for marking changes that must be merged into 2.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants