[Backport 2.6] [Backport 2.x] [Feature] create detector | make data source multi select field (#424) #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…#429) * [FEATURE] Detector must have at least one alert set #288 * [BUG] Create detector | Interval field can be empty #378 * Adjust styling for Finding details flyout #369 * unit tests * detector unit tests * detector unit tests * detector unit tests * detector unit tests * detector unit tests * detector unit tests * detector unit tests * detector unit tests * detector unit tests * unit tests review * unit tests review * unit tests review * unit tests review * unit tests review * unit tests review * unit tests review * unit tests review * Feature/update vertical domain #372 * Unit tests for public components #383 * Unit tests for public components #383 * Unit tests for public components #383 * Unit tests for public components #383 * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 * PR code review * PR code review * PR code review * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * [FEATURE] Create detector | Make data source multi-select field #419 * unit tests fix --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit ec2e438)
amsiglan
approved these changes
Feb 22, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.6 #436 +/- ##
==========================================
- Coverage 35.07% 34.96% -0.12%
==========================================
Files 112 112
Lines 3079 3109 +30
Branches 478 488 +10
==========================================
+ Hits 1080 1087 +7
- Misses 1885 1908 +23
Partials 114 114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ec2e438 from #429