Fixes UX issues with edit detector pages #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#393 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into feature/add_edit_detector_link_to_breadcrumbs # Conflicts: # public/pages/Detectors/components/UpdateBasicDetails/UpdateBasicDetails.tsx # public/pages/Detectors/components/UpdateRules/UpdateRules.tsx
…-analytics-dashboards-plugin into feature/add_edit_detector_link_to_breadcrumbs
…#393 Signed-off-by: Jovan Cvetkovic <[email protected]>
…#393 Signed-off-by: Jovan Cvetkovic <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 15.36% 15.32% -0.05%
==========================================
Files 111 111
Lines 2961 2976 +15
Branches 488 490 +2
==========================================
+ Hits 455 456 +1
- Misses 2467 2481 +14
Partials 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Flaky windows-latest test fail on request timeout could be related to GitHub windows-latest runner issue: #3577 |
Thank you for the context! |
AWSHurneyt
approved these changes
Feb 9, 2023
1 task
1 task
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan
approved these changes
Feb 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
* [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 85f2ee4)
amsiglan
pushed a commit
that referenced
this pull request
Feb 15, 2023
* [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 85f2ee4) Co-authored-by: Jovan Cvetkovic <[email protected]>
amsiglan
pushed a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…ensearch-project#411) * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 85f2ee4) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ensearch-project#411) * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 85f2ee4) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add edit detector links into breadcrumbs #393 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 85f2ee4) Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes various UX issues like missing texts, missing wrappers, and missing breadcrumbs links.
Issues Resolved
Resolves #401
Resolves #402
Resolves #403
Resolves #393
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.