Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [FEATURE] Add "Create detector" item to the breadcrumbs #394 #399

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a137a80 from #396

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit a137a80)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team January 31, 2023 21:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #399 (a137a80) into 2.x (a8e85cc) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head a137a80 differs from pull request most recent head 3aef2c5. Consider uploading reports for the commit 3aef2c5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x     #399      +/-   ##
==========================================
- Coverage   15.45%   15.36%   -0.09%     
==========================================
  Files         112      111       -1     
  Lines        3029     2961      -68     
  Branches      501      488      -13     
==========================================
- Hits          468      455      -13     
+ Misses       2522     2467      -55     
  Partials       39       39              
Impacted Files Coverage Δ
...ytics-dashboards-plugin/public/utils/validation.ts 19.23% <0.00%> (-1.61%) ⬇️
...lytics-dashboards-plugin/public/utils/constants.ts 81.81% <0.00%> (ø)
...pages/CreateDetector/containers/CreateDetector.tsx 8.42% <0.00%> (ø)
...c/pages/Rules/components/RuleEditor/RuleEditor.tsx

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amsiglan amsiglan merged commit 0b94065 into 2.x Jan 31, 2023
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…oject#394 (opensearch-project#396) (opensearch-project#399)

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit a137a80)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…oject#394 (opensearch-project#396) (opensearch-project#399)

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit a137a80)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this pull request Mar 16, 2024
…399)

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit a137a80)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants