Hide Security Analytics sidebar for edit detector pages #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>
…sidebar visible. opensearch-project#386 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into edit_detector_no_sidebar
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 15.41% 15.44% +0.03%
==========================================
Files 109 109
Lines 2887 2887
Branches 476 476
==========================================
+ Hits 445 446 +1
+ Misses 2403 2402 -1
Partials 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
amsiglan
approved these changes
Jan 31, 2023
…-analytics-dashboards-plugin into edit_detector_no_sidebar
AWSHurneyt
approved these changes
Jan 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c8a9410)
amsiglan
pushed a commit
that referenced
this pull request
Jan 31, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c8a9410) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…roject#388) (opensearch-project#398) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector edit pages should not have the Security Analytics sidebar visible. opensearch-project#386 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c8a9410) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…roject#388) (opensearch-project#398) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector edit pages should not have the Security Analytics sidebar visible. opensearch-project#386 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c8a9410) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector edit pages should not have the Security Analytics sidebar visible. #386 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c8a9410) Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hides Security Analytics sidebar for edit detector pages.
New Screenshots
Issues Resolved
Closes #386
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.