Detector details page wrappers fix #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into detector_details_page_wrapper_384
…page opensearch-project#384 Signed-off-by: Jovan Cvetkovic <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 15.36% 15.36%
=======================================
Files 111 111
Lines 2961 2961
Branches 488 488
=======================================
Hits 455 455
Misses 2467 2467
Partials 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…-analytics-dashboards-plugin into detector_details_page_wrapper_384
AWSHurneyt
approved these changes
Jan 31, 2023
…-analytics-dashboards-plugin into detector_details_page_wrapper_384
amsiglan
reviewed
Jan 31, 2023
amsiglan
approved these changes
Jan 31, 2023
|
The test failure is in an unrelated part of the app, so it is safe to merge this change |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector details shouldn't have a wrapper around the whole page #384 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 67e02f2)
amsiglan
pushed a commit
that referenced
this pull request
Feb 1, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector details shouldn't have a wrapper around the whole page #384 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 67e02f2) Co-authored-by: Jovan Cvetkovic <[email protected]>
amsiglan
pushed a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
* [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector details shouldn't have a wrapper around the whole page opensearch-project#384 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…ch-project#400) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector details shouldn't have a wrapper around the whole page opensearch-project#384 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 67e02f2) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ch-project#400) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector details shouldn't have a wrapper around the whole page opensearch-project#384 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 67e02f2) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] The detector details shouldn't have a wrapper around the whole page #384 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 67e02f2) Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves:
[BUG] The detector details shouldn't have a wrapper around the whole page
[BUG] The detector details shouldn't have a wrapper around the Active rules table
Issues Resolved
Closes #384
Closes #385
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.