Upgrade vega tooltips to use custom tooltip format #368

jovancacvetkovic · 2023-01-16T12:22:30Z

Description

Upgrades vega tooltips to use custom tooltip format

Issues Resolved

Closes #254

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>

…-analytics-dashboards-plugin

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

Signed-off-by: Jovan Cvetkovic <[email protected]>

jovancacvetkovic · 2023-01-16T14:48:36Z

@amsiglan note that this is only for code preview. The vega tooltip needs an upgrade in order for this to work.

…-analytics-dashboards-plugin

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

public/utils/helpers.tsx

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

…#368 Signed-off-by: Jovan Cvetkovic <[email protected]>

…t#378 Signed-off-by: Jovan Cvetkovic <[email protected]>

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

codecov-commenter · 2023-01-23T19:24:54Z

Codecov Report

Merging #368 (5d7dab6) into main (0150c89) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   37.27%   37.27%   -0.01%     
==========================================
  Files         111      111              
  Lines        2986     3021      +35     
  Branches      457      469      +12     
==========================================
+ Hits         1113     1126      +13     
- Misses       1758     1778      +20     
- Partials      115      117       +2

Impacted Files	Coverage Δ
...alytics-dashboards-plugin/public/utils/helpers.tsx	`57.29% <0.00%> (-6.35%)`	⬇️
...ts/UpdateAlertConditions/UpdateAlertConditions.tsx	`51.47% <0.00%> (-3.71%)`	⬇️
...nts/ConfigureAlerts/containers/ConfigureAlerts.tsx	`53.33% <0.00%> (+2.05%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jovan Cvetkovic <[email protected]>

…-analytics-dashboards-plugin into unit_tests_for_public_components

Signed-off-by: Jovan Cvetkovic <[email protected]>

…-analytics-dashboards-plugin into unit_tests_for_public_components

Signed-off-by: Jovan Cvetkovic <[email protected]>

…-analytics-dashboards-plugin into unit_tests_for_public_components

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]>

…-analytics-dashboards-plugin into unit_tests_for_public_components

[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

jovancacvetkovic · 2023-02-16T17:59:31Z

@amsiglan this PR #3359 is merged.

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

Signed-off-by: Jovan Cvetkovic <[email protected]>

jovancacvetkovic · 2023-02-19T17:54:36Z

@amsiglan PR has been updated and tested with the latest Dashboard main branch.

…-analytics-dashboards-plugin into unit_tests_for_public_components

Signed-off-by: Jovan Cvetkovic <[email protected]>

…/jovancacvetkovic/security-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

Signed-off-by: Jovan Cvetkovic <[email protected]>

…earch-project#419 Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Upgrade Vega-tooltips plugin version #254 Signed-off-by: Jovan Cvetkovic <[email protected]> * Upgrade vega tooltips to use custom tooltip format #368 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature/update vertical domain #372 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector | Make data source multi-select field #419 Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests fix Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 9a62208)

* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Upgrade Vega-tooltips plugin version #254 Signed-off-by: Jovan Cvetkovic <[email protected]> * Upgrade vega tooltips to use custom tooltip format #368 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature/update vertical domain #372 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector | Make data source multi-select field #419 Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests fix Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 9a62208) Co-authored-by: Jovan Cvetkovic <[email protected]>

…t#368) (opensearch-project#434) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Upgrade Vega-tooltips plugin version opensearch-project#254 Signed-off-by: Jovan Cvetkovic <[email protected]> * Upgrade vega tooltips to use custom tooltip format opensearch-project#368 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty opensearch-project#378 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * detector unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests review Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature/update vertical domain opensearch-project#372 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR code review Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector | Make data source multi-select field opensearch-project#419 Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests fix Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 9a62208) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>

jovancvetkovic3006 added 4 commits January 9, 2023 10:28

[FEATURE] Detector must have at least one alert set opensearch-projec…

f78f8dd

…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/security…

1ea796c

…-analytics-dashboards-plugin

Merge branch 'main' of https://github.com/opensearch-project/security…

a7f7b7a

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

[FEATURE] Upgrade Vega-tooltips plugin version opensearch-project#254

1180e2c

Signed-off-by: Jovan Cvetkovic <[email protected]>

jovancacvetkovic requested a review from a team January 16, 2023 12:22

jovancvetkovic3006 added 2 commits January 16, 2023 18:53

Merge branch 'main' of https://github.com/opensearch-project/security…

0d514d8

…-analytics-dashboards-plugin

Merge branch 'main' of https://github.com/opensearch-project/security…

b8f3399

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

amsiglan reviewed Jan 19, 2023

View reviewed changes

public/utils/helpers.tsx Outdated Show resolved Hide resolved

amsiglan reviewed Jan 19, 2023

View reviewed changes

public/utils/helpers.tsx Outdated Show resolved Hide resolved

jovancvetkovic3006 added 4 commits January 19, 2023 22:02

Merge branch 'main' of https://github.com/opensearch-project/security…

4c03561

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

Upgrade vega tooltips to use custom tooltip format opensearch-project…

40793f0

…#368 Signed-off-by: Jovan Cvetkovic <[email protected]>

[BUG] Create detector | Interval field can be empty opensearch-projec…

ff8117e

…t#378 Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/security…

2316863

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

jovancvetkovic3006 added 15 commits January 24, 2023 08:04

Adjust styling for Finding details flyout opensearch-project#369

b308059

Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/security…

73fae1f

…-analytics-dashboards-plugin into unit_tests_for_public_components

unit tests

7a41744

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

06be7da

Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/security…

f0ccd00

…-analytics-dashboards-plugin into unit_tests_for_public_components

detector unit tests

6bf765e

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

36b6390

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

c23a669

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

ce0944b

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

d37fb41

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

d523098

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

8ef0bd0

Signed-off-by: Jovan Cvetkovic <[email protected]>

detector unit tests

9c71aa8

Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/security…

bc50e0a

…-analytics-dashboards-plugin into unit_tests_for_public_components

Merge branch 'main' of https://github.com/opensearch-project/security…

a659826

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

jovancvetkovic3006 added 5 commits February 11, 2023 13:11

Unit tests for public components opensearch-project#383

8a2246b

[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/security…

fa436c4

…-analytics-dashboards-plugin into unit_tests_for_public_components

Unit tests for public components opensearch-project#383

95c6db8

[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <[email protected]>

PR code review

6dab0ee

Signed-off-by: Jovan Cvetkovic <[email protected]>

PR code review

239150f

Signed-off-by: Jovan Cvetkovic <[email protected]>

jovancvetkovic3006 added 4 commits February 19, 2023 18:06

Merge branch 'main' of https://github.com/opensearch-project/security…

9b212fb

…-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

PR code review

9d747b3

Signed-off-by: Jovan Cvetkovic <[email protected]>

PR code review

5d7dab6

Signed-off-by: Jovan Cvetkovic <[email protected]>

PR code review

20d215c

Signed-off-by: Jovan Cvetkovic <[email protected]>

jovancvetkovic3006 added 4 commits February 19, 2023 19:38

Merge branch 'main' of https://github.com/opensearch-project/security…

94a8788

…-analytics-dashboards-plugin into unit_tests_for_public_components

PR code review

c86731e

Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'unit_tests_for_public_components' of https://github.com…

efe585d

…/jovancacvetkovic/security-analytics-dashboards-plugin into feature/upgrade_vega_tooltips

PR code review

4a1a539

Signed-off-by: Jovan Cvetkovic <[email protected]>

amsiglan added backport 2.x backport 2.6 Used for marking changes that must be merged into 2.6 branch labels Feb 20, 2023

jovancvetkovic3006 added 2 commits February 21, 2023 13:43

[FEATURE] Create detector | Make data source multi-select field opens…

dcc5d27

…earch-project#419 Signed-off-by: Jovan Cvetkovic <[email protected]>

unit tests fix

d124223

Signed-off-by: Jovan Cvetkovic <[email protected]>

amsiglan approved these changes Feb 22, 2023

View reviewed changes

sbcd90 approved these changes Feb 22, 2023

View reviewed changes

amsiglan merged commit 9a62208 into opensearch-project:main Feb 22, 2023

opensearch-trigger-bot bot mentioned this pull request Feb 22, 2023

[Backport 2.x] Upgrade vega tooltips to use custom tooltip format #434

Merged

opensearch-trigger-bot bot mentioned this pull request Feb 22, 2023

[Backport 2.6] Upgrade vega tooltips to use custom tooltip format #435

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade vega tooltips to use custom tooltip format #368

Upgrade vega tooltips to use custom tooltip format #368

jovancacvetkovic commented Jan 16, 2023

jovancacvetkovic commented Jan 16, 2023

codecov-commenter commented Jan 23, 2023 •

edited

Loading

jovancacvetkovic commented Feb 16, 2023

jovancacvetkovic commented Feb 19, 2023

Upgrade vega tooltips to use custom tooltip format #368

Upgrade vega tooltips to use custom tooltip format #368

Conversation

jovancacvetkovic commented Jan 16, 2023

Description

Issues Resolved

Check List

jovancacvetkovic commented Jan 16, 2023

codecov-commenter commented Jan 23, 2023 • edited Loading

Codecov Report

jovancacvetkovic commented Feb 16, 2023

jovancacvetkovic commented Feb 19, 2023

codecov-commenter commented Jan 23, 2023 •

edited

Loading