Improved field mapping UX #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
sbcd90
approved these changes
Jan 10, 2023
AWSHurneyt
approved these changes
Jan 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
* fixed issues; improved UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted change Signed-off-by: Amardeepsingh Siglani <[email protected]> * override default mapping with created Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d0e184d)
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 11, 2023
* fixed issues; improved UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted change Signed-off-by: Amardeepsingh Siglani <[email protected]> * override default mapping with created Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d0e184d) Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…t#337) * fixed issues; improved UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted change Signed-off-by: Amardeepsingh Siglani <[email protected]> * override default mapping with created Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d0e184d) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…t#337) * fixed issues; improved UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted change Signed-off-by: Amardeepsingh Siglani <[email protected]> * override default mapping with created Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit d0e184d) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amardeepsingh Siglani [email protected]
Description
Enhanced the helper text and controls used for field mapping step in detector creation.
Also fixed crashes when user removes existing mapping
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.