Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rules view in detector details #310

Conversation

amsiglan
Copy link
Collaborator

Description

Improves the rules table view by adding custom width to columns. Also added sorting caability.

Issues Resolved

NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amsiglan amsiglan requested a review from a team January 10, 2023 17:26
@amsiglan amsiglan merged commit 9dba6c1 into opensearch-project:main Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* updated column widths

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* improved typography; removed log type filter

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 9dba6c1)
AWSHurneyt pushed a commit that referenced this pull request Jan 10, 2023
* updated column widths

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* improved typography; removed log type filter

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 9dba6c1)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…search-project#314)

* updated column widths

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* improved typography; removed log type filter

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 9dba6c1)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…search-project#314)

* updated column widths

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* improved typography; removed log type filter

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 9dba6c1)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants