Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated field mapping UX; disabled windows run for cypress #307

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Jan 10, 2023

Signed-off-by: Amardeepsingh Siglani [email protected]

Description

Splits field mapping table into Edit and Read-only fields tables when configuring field mappings during detector creation.
image

This PR is also disabling windows test run for cypress tests as it is very flaky. Will investigate this in a follow up PR

Issues Resolved

#144
#293

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amsiglan amsiglan requested a review from a team January 10, 2023 15:01
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan added the active The work item is being worked on actively by a developer label Jan 10, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan added backport 2.x and removed active The work item is being worked on actively by a developer labels Jan 10, 2023
@amsiglan amsiglan merged commit 3f45498 into opensearch-project:main Jan 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-307-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f454983fe76c965dc52524cefba4a811d69df41
# Push it to GitHub
git push --set-upstream origin backport/backport-307-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-307-to-2.x.

amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jan 10, 2023
…h-project#307)

* updated field mapping UX; disabled windows run for cypress

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added timestamp field to list of unmapped fields

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Jan 10, 2023
* Updated field mapping UX; disabled windows run for cypress (#307)

* updated field mapping UX; disabled windows run for cypress

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added timestamp field to list of unmapped fields

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…nsearch-project#311)

* Updated field mapping UX; disabled windows run for cypress (opensearch-project#307)

* updated field mapping UX; disabled windows run for cypress

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added timestamp field to list of unmapped fields

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…nsearch-project#311)

* Updated field mapping UX; disabled windows run for cypress (opensearch-project#307)

* updated field mapping UX; disabled windows run for cypress

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added timestamp field to list of unmapped fields

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants