Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress windows tests fix #296

Merged

Conversation

jovancacvetkovic
Copy link

Description

Fixes cypress windows tests

Issues Resolved

Closes #295

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jovancacvetkovic jovancacvetkovic requested a review from a team January 9, 2023 22:05
@amsiglan amsiglan merged commit a82125a into opensearch-project:main Jan 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-296-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a82125ac8fde7a11d3fd13237c5a7d72f47dbfb7
# Push it to GitHub
git push --set-upstream origin backport/backport-296-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-296-to-2.x.

amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jan 10, 2023
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests opensearch-project#295

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests opensearch-project#295

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan added a commit that referenced this pull request Jan 10, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests #295

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests #295

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic deleted the bugfix/cypress_windows_fix branch January 29, 2023 11:04
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…t#305)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests opensearch-project#295

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests opensearch-project#295

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…t#305)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests opensearch-project#295

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [TASK] Investigate and fix cypress windows tests opensearch-project#295

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Investigate and fix cypress windows tests
4 participants