Streamline rules request #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into unit_and_cypress_tests # Conflicts: # public/pages/Overview/utils/helper.test.ts # public/pages/Overview/utils/helpers.ts
…project#278 Signed-off-by: Jovan Cvetkovic <[email protected]>
…project#278 Signed-off-by: Jovan Cvetkovic <[email protected]>
sbcd90
approved these changes
Jan 9, 2023
amsiglan
approved these changes
Jan 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
* [TASK] Add unit tests for util methods #268 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor #278 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor #278 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 5508caa)
|
The windows cypress test failure was due to a slower loading time and unrelated to the changes made in this PR, hence it was okay to merge the changes. |
amsiglan
pushed a commit
that referenced
this pull request
Jan 9, 2023
* [TASK] Add unit tests for util methods #268 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor #278 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor #278 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 5508caa) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…#286) * [TASK] Add unit tests for util methods opensearch-project#268 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor opensearch-project#278 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor opensearch-project#278 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 5508caa) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…#286) * [TASK] Add unit tests for util methods opensearch-project#268 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor opensearch-project#278 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Streamline rules request via RuleViewModelActor opensearch-project#278 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 5508caa) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Streamline rules request via RuleViewModelActor
Issues Resolved
Closes #278
Closes #268
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.